Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing logging for critical exceptions #917

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Conversation

orchestr7
Copy link
Member

What's done:

  • adding information about the file and node for critical errors

### What's done:
- adding information about the file and node for critical errors
Root cause of the problem is in [${node.getFilePath()}] file.
Node, where the problem appeared:
${node.prettyPrint()}
""", internalError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
""", internalError
""".trimIndent(), internalError

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

### What's done:
- adding information about the file and node for critical errors
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #917 (e5a7f0e) into master (2c3c434) will decrease coverage by 0.03%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #917      +/-   ##
============================================
- Coverage     84.18%   84.14%   -0.04%     
  Complexity     2373     2373              
============================================
  Files           101      101              
  Lines          6002     6006       +4     
  Branches       1772     1772              
============================================
+ Hits           5053     5054       +1     
- Misses          260      263       +3     
  Partials        689      689              
Flag Coverage Δ
unittests 84.14% <44.44%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 61.90% <44.44%> (-8.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3c434...e5a7f0e. Read the comment docs.

### What's done:
- adding information about the file and node for critical errors
### What's done:
- adding information about the file and node for critical errors
### What's done:
- adding information about the file and node for critical errors
@orchestr7 orchestr7 merged commit b57b71d into master Jun 10, 2021
@petertrr petertrr deleted the feature/error-logging branch July 1, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants