-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing logging for critical exceptions #917
Conversation
### What's done: - adding information about the file and node for critical errors
Root cause of the problem is in [${node.getFilePath()}] file. | ||
Node, where the problem appeared: | ||
${node.prettyPrint()} | ||
""", internalError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""", internalError | |
""".trimIndent(), internalError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What's done: - adding information about the file and node for critical errors
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
============================================
- Coverage 84.18% 84.14% -0.04%
Complexity 2373 2373
============================================
Files 101 101
Lines 6002 6006 +4
Branches 1772 1772
============================================
+ Hits 5053 5054 +1
- Misses 260 263 +3
Partials 689 689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: - adding information about the file and node for critical errors
### What's done: - adding information about the file and node for critical errors
### What's done: - adding information about the file and node for critical errors
What's done: