Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test #480

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Changed test #480

merged 1 commit into from
Jan 24, 2023

Conversation

Cheshiriks
Copy link
Member

Changed test

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #480 (7a93993) into main (1fe5103) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #480   +/-   ##
=========================================
  Coverage     47.46%   47.46%           
  Complexity      159      159           
=========================================
  Files            53       53           
  Lines          1852     1852           
  Branches        316      316           
=========================================
  Hits            879      879           
  Misses          840      840           
  Partials        133      133           
Flag Coverage Δ
unittests 47.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✔️ ±0   8m 14s ⏱️ -20s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 7a93993. ± Comparison against base commit 1fe5103.

@github-actions
Copy link

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✔️ ±0   10m 54s ⏱️ - 2m 37s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 7a93993. ± Comparison against base commit 1fe5103.

@github-actions
Copy link

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✔️ +1   8m 51s ⏱️ - 1m 44s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0  - 1 

Results for commit 7a93993. ± Comparison against base commit 1fe5103.

@kgevorkyan
Copy link
Member

Why do we need to change this?

@Cheshiriks
Copy link
Member Author

Why do we need to change this?

This is for a test with the same names. Now the tests have the same content. Even if the names are mixed up, the test will succeed because the content is the same.

@kgevorkyan
Copy link
Member

Even if the names are mixed up, the test will succeed because the content is the same.

But it was succeed with different content too, why did you said, that it is because the content is the same.?

@Cheshiriks Cheshiriks merged commit ae96d32 into main Jan 24, 2023
@Cheshiriks Cheshiriks deleted the bugfix/change-test branch January 24, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants