Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant perfomance improvement for very large responses #127

Merged
1 commit merged into from
Jan 4, 2011

Conversation

jvdp
Copy link
Contributor

@jvdp jvdp commented Jan 2, 2011

I'm working with a webservice that returns really large responses (some over 5mb) and after switching from Savon 0.7.9 to 0.8 these took a very long time to process (not sure how long, didn't want to wait for over an hour.)

Turns out this is caused by the regex that checks for a soap fault element. This commit changes the check so that the regex only checks the first 1000 chars of the response string. It should work properly in most (if not all) cases; the tests still pass and the soap fault fixtures range in size from 270 to 672 chars.

@rubiii
Copy link
Contributor

rubiii commented Jan 4, 2011

thanks! v0.8.2 contains your change.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants