Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savon 0.9.8 breaks compatibility with bundler and older versions of rubygems on 1.8.7 #267

Closed
jrafanie opened this issue Feb 17, 2012 · 9 comments
Milestone

Comments

@jrafanie
Copy link

I don't know if it's intentional but this commit: rubiii/savon@335d01a#savon.gemspec seems to break compatibility with ruby 1.8.7-p358 with rubygems 1.3.7.

See: https://gist.github.com/1855248

@rubiii
Copy link
Contributor

rubiii commented Feb 17, 2012

the commit you're referring to is not included in v0.9.8, but is supposed to be released asap
to fix this problem instead. i'll leave this issue open until v0.9.9 is released.

sorry for the inconvenience!

@rubiii
Copy link
Contributor

rubiii commented Feb 17, 2012

please try upgrading to v0.9.9 which should fix this problem.

@rubiii rubiii closed this as completed Feb 17, 2012
@jrafanie
Copy link
Author

Ok, i'll try it when rubygems.org is back up ;-) Did you push two versions of 0.9.8? Because the one I installed from rubygems.org had the encoding header and zentest change to support jruby.

My gist shows the gempsec that was brought down having this:
WARNING: ArgumentError: Illformed requirement ["#YAML::Syck::DefaultKey:0x1055d0cb8 4.5.0"]>
encoding: utf-8

Very weird.

@rubiii
Copy link
Contributor

rubiii commented Feb 18, 2012

just installed 0.9.8 again and it definitely doesn't include the changes.
so 0.9.9 should work fine.

@jlecour
Copy link

jlecour commented Feb 18, 2012

Yep, this one fucked me up real good :-) Thanks for this quick fix.

@jrafanie
Copy link
Author

Thanks @rubiii for the quick response. In case others run into this, wherever I got the bad 0.9.8 version from (rubygems.org) on Friday, I was not able to "gem uninstall savon" to remove it due to the invalid specification:

WARNING: Invalid .gemspec format in '/Users/joerafaniello/.rvm/gems/ruby-1.8.7-p352@trunk/specifications/savon-0.9.8.gemspec'
ERROR: While executing gem ... (Gem::InstallError)

I had to manually edit the .gemspec referenced above to change what appears to be 3 invalid ZenTest dependencies like this: ["#YAML::Syck::DefaultKey:0x1110818f0 4.5.0"] to "4.5". But once done, I was able uninstall 0.9.8 and a subsequent bundle update brought down 0.9.9 without any issue.

@jlecour
Copy link

jlecour commented Feb 21, 2012

Thanks @jrafanie, I should have explained how I've done, since I was in the same situation.

I've manually deleted the files/directories :

  • shared/bundle/ruby/1.8/cache/savon-0.9.8.gem
  • shared/bundle/ruby/1.8/gems/savon-0.9.8
  • shared/bundle/ruby/1.8/specifications/savon-0.9.8.gemspec

@jrafanie
Copy link
Author

@jlecour, I did that too the first time. After reinstalling using the bad 0.9.8, I edited the gemspec to see if that would fix the uninstallation and it did.

@rrevi
Copy link

rrevi commented May 16, 2012

rubiii, thanks for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants