Compute correct namespace for message tags #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perfect pull request! thanks jordan. |
rubiii
added a commit
that referenced
this pull request
Jul 2, 2013
Compute correct namespace for message tags
|
Glad to help. Any idea of the timeframe for 2.3.0? |
|
not really. i'm currently looking through various issues in related projects like httpi and wasabi trying to coordinate all those releases and make sure they work well with the new savon release. but you can follow #481 for updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation name (e.g. "example_operation") was being used to look up a tag-specific namespace, but @used_namespaces is a map of tag names (e.g. "exampleOperation") to namespaces
Found this issue using the VIES VAT number validation service, so added a spec test to make sure the message tag gets the correct namespace.