Namespaced entries in the xml #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix for namespaced entries in SOAP response XML. closed by 0c3aa5e. |
|
please try savon 0.8.0.beta.1 |
calamitas
pushed a commit
to calamitas/savon
that referenced
this pull request
Jun 7, 2011
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
I've been using Savon for a couple of weeks now and first off I'd like to say you did a great job. I's easy peasy to use it ;)
That being said, I'm working with legacy webservices in a client that has very strict rules about their xml and because of that I believe I might have found a small bug in your code.
If you take a look at my last commit, you'll see I added both a integration and a unit test - although in this case I believe the unit test would suffice.
I also included a sample xml file with the integration test to give you a better idea of the kind of xml I'm talking about.
Feel free to contact me in case none of this makes sense ;)
Cheers,
Leonardo Borges