Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savon doesn't guess upper_camelcased action names with WSDL disabled #96

Closed
bensomers opened this issue Oct 12, 2010 · 6 comments
Closed

Comments

@bensomers
Copy link

Working with a service that uses upper_camelcase actions, and working with WSDL disabled for performance reasons. I imagine there's a call of #to_soap_key happening somewhere that's not supposed to be. Assuming this is a bug, because this behavior is contradictory to what's listed in the documentation for disabling the WSDL.

Following to reproduce, when working with a service that uses upper_camelcase names:
c = Savon::Client("#{url without wsdl}")
c.action_name!
produces
SOAP request:
SOAPAction: actionName, Content-Type: text/xml;charset=UTF-8
while
c.ActionName!
still produces
SOAPAction: actionName, Content-Type: text/xml;charset=UTF-8

@rubiii
Copy link
Contributor

rubiii commented Oct 12, 2010

looks like you're right. sorry. i'm pretty sure this does not happen in the 0.8 version (which should be released soon). but i'll take another look and make sure this is fixed.

@rubiii
Copy link
Contributor

rubiii commented Oct 12, 2010

this is what's causing your problem in the current version:
http://github.com/rubiii/savon/blob/master/lib/savon/wsdl.rb#L116

@rubiii
Copy link
Contributor

rubiii commented Oct 12, 2010

only symbols should be converted to lowerCamelCase. it's fixed in the eight branch:
http://github.com/rubiii/savon/blob/eight/lib/savon/client.rb#L112

@bensomers
Copy link
Author

Awesome!

@rubiii
Copy link
Contributor

rubiii commented Oct 29, 2010

please try savon 0.8.0.beta.1

@rubiii
Copy link
Contributor

rubiii commented Dec 20, 2010

released v0.8.0 which should solve this problem.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants