Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Highlighting of Global Variables #104

Open
paulhdk opened this issue Jan 5, 2025 · 0 comments
Open

Semantic Highlighting of Global Variables #104

paulhdk opened this issue Jan 5, 2025 · 0 comments

Comments

@paulhdk
Copy link

paulhdk commented Jan 5, 2025

I recently switched to melange and have been loving it so far!

I have semantic highlighting enabled and noticed that function parameters are highlighted in bold whereas global variables are highlighted the same as local variables. This appears to be the same with gruvbox.nvim, too.

Personally, I find this counterintuitive, as I would prefer function parameters and global variables to be highlighted the same and local variables to be highlighted in a different colour, so I can distinguish what is local from what is/could be global. This is the way it appears to be handled in kanagawa.nvim.

Would you welcome a PR for such a change or is there a reason why semantic highlights are currently defined this way?

I also find the bold white font a little too intense and distracting, but that might be just me. I presume the reason for the bold font is that it doesn't introduce another colour and therefore doesn't mess with the melange philosophy of warm colours for control flow and cold colours for data?

What do you think?

@paulhdk paulhdk changed the title Semantic highlighting of global variables Semantic Highlighting of Global Variables Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant