How to use fasthttp TimeoutHandler

[losingle]

We need to give the timeout request a specific status code

https://godoc.org/github.com/valyala/fasthttp#TimeoutHandler

TimeoutErrorWithCode is discouraged

[savsgio]

Hi @losingle,

Do you need ctx.TimeoutErrorWithCode(...) or TimeoutHandler??

[savsgio]

You could call to ctx.TimeoutErrorWithCode() directly, as you would do in native fasthttp, in atreugo handler.

However, TimeoutHandler is not implemented yet. I will add it soon.

[losingle]

You could call to ctx.TimeoutErrorWithCode() directly, as you would do in native fasthttp, in atreugo handler.

However, TimeoutHandler is not implemented yet. I will add it soon.

Very much looking forward to this feature.
I can only use first eliminating CTX references in goroutines now

[savsgio]

Here you have the feature: https://godoc.org/github.com/savsgio/atreugo#Atreugo.TimeoutPath 😄

Thanks for your contribution.

[losingle]

Here you have the feature: https://godoc.org/github.com/savsgio/atreugo#Atreugo.TimeoutPath 😄

Thanks for your contribution.

How do I change the status code ?
eg. valyala/fasthttp@38473d3

[savsgio]

TimeoutPath always return 408 if timeout is reached like fasthttp in https://godoc.org/github.com/valyala/fasthttp#TimeoutHandler

If you want to set a custom status code in response, use https://godoc.org/github.com/savsgio/atreugo#RequestCtx or ctx.SetStatusCode(<yourStatusCode>)

[savsgio]

I think you are supervising the timeout manually, right? with channels, selects, context or something similar.

if it's truth, not use PathTimeout or ctx.TimeoutErrorWithCode(...), just finish the handler and return the response with your own status code

[losingle]

well, as if only timeout manually
thank you

[savsgio]

So, why do you need to change the status code when timeout?

I see your PR valyala/fasthttp#589 in fasthttp.

I think so, it's not recommended to return another status code if timeout

[losingle]

Yes, normally, there is no need to change the status code, following the rules of HTTP.
However, some business scenarios may be needed, and I think fasthttp, as a network base library, should give control to the developers.
Because our business will need to timeout the request, return 204 status code

[savsgio]

I saw that erik merged your PR, when release a new version of fasthttp i will add it in atreugo. ;)

[savsgio]

I've just release a new version v8.1.0 with TimeoutWithCodePath support :)