Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(journey-maps): v1 route hover #1829

Merged
merged 12 commits into from
Mar 9, 2023
Merged

feat(journey-maps): v1 route hover #1829

merged 12 commits into from
Mar 9, 2023

Conversation

mstankala
Copy link
Contributor

No description provided.

@mstankala mstankala changed the title Feature/journey maps v2 route hover Feature/journey maps v1 route hover Feb 23, 2023
@github-actions
Copy link

Preview ready from f323619 at 23.2.2023, 12:46:31:

@mstankala mstankala marked this pull request as ready for review February 23, 2023 13:48
swiss-chris
swiss-chris requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@swiss-chris swiss-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstankala machst du auch noch diesen change hier ?

#1828 (comment)

@kyubisation kyubisation changed the title Feature/journey maps v1 route hover feat(journey-maps): v1 route hover Feb 23, 2023
sebisteiner
sebisteiner approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@sebisteiner sebisteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstankala mstankala marked this pull request as draft February 24, 2023 12:28
@mstankala mstankala marked this pull request as ready for review February 24, 2023 12:29
@mstankala mstankala marked this pull request as draft February 24, 2023 12:31
@github-actions
Copy link

Preview ready from 3f9c06b at 24.2.2023, 13:57:21:

@github-actions
Copy link

Preview ready from 205124c at 27.2.2023, 15:45:33:

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Preview ready from bdd76ec at 1.3.2023, 07:35:22:

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Preview ready from eee6466 at 1.3.2023, 08:14:33:

@mstankala mstankala marked this pull request as ready for review March 8, 2023 13:40
@mstankala
Copy link
Contributor Author

Done

@swiss-chris swiss-chris self-requested a review March 8, 2023 13:53
swiss-chris
swiss-chris previously approved these changes Mar 8, 2023
View reviewed changes
@swiss-chris swiss-chris self-requested a review March 8, 2023 14:03
@swiss-chris swiss-chris dismissed their stale review March 8, 2023 14:04

I don't have time to review the whole PR right now

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Preview ready from 7783c93 at 8.3.2023, 13:53:54:

sebisteiner
sebisteiner approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@sebisteiner sebisteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kyubisation kyubisation merged commit 001f4ed into main Mar 9, 2023
@kyubisation kyubisation deleted the feature/journey-maps-v2-route-hover branch March 9, 2023 12:43
sbb-design-systems-bot bot pushed a commit that referenced this pull request Mar 9, 2023
@mstankala
feat(journey-maps): v1 route hover (#1829)
d664b24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebisteiner sebisteiner sebisteiner approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

@mhaertwig mhaertwig Awaiting requested review from mhaertwig mhaertwig is a code owner

@swiss-chris swiss-chris Awaiting requested review from swiss-chris swiss-chris is a code owner

Assignees
No one assigned
Labels
preview-available target: 15.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstankala @swiss-chris @sebisteiner @kyubisation