-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(journey-maps): add web-component examples page #1948
Merged
mhaertwig
merged 7 commits into
main
from
feature/cdi/ROKAS-1468-add-web-component-examples
Aug 10, 2023
Merged
feat(journey-maps): add web-component examples page #1948
mhaertwig
merged 7 commits into
main
from
feature/cdi/ROKAS-1468-add-web-component-examples
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: ROKAS-1468
swiss-chris
requested review from
mstankala,
kyubisation,
jeripeierSBB and
mhaertwig
as code owners
July 24, 2023 14:15
Refs: ROKAS-1468
Refs: ROKAS-1468
Refs: ROKAS-1468
swiss-chris
changed the title
feat(journey-maps): add web-component examples on Stackblitz
feat(journey-maps): add web-component examples page
Jul 24, 2023
Refs: ROKAS-1468
Refs: ROKAS-1468
mstankala
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mhaertwig dieser PR ist schon länger offen. Könnt ihr den mergen ? |
mhaertwig
approved these changes
Aug 10, 2023
…8-add-web-component-examples # Conflicts: # src/journey-maps/web-component/web-component.md
mhaertwig
deleted the
feature/cdi/ROKAS-1468-add-web-component-examples
branch
August 10, 2023 10:39
sbb-design-systems-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Chris Dickinson <“christopher.dickinson@sbb.ch”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: ROKAS-1468