Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(journey-maps): show geolocation with custom control #2011

Merged

Conversation

swiss-chris
Copy link
Contributor

No description provided.

Copy link
Collaborator

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrity check failure might be related to my comments

src/journey-maps/angular/journey-maps.module.ts Outdated Show resolved Hide resolved
src/journey-maps/angular/journey-maps.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mstankala mstankala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kyubisation kyubisation merged commit cdc9444 into main Sep 19, 2023
16 checks passed
@kyubisation kyubisation deleted the feature/cdi/ROKAS-100-show-geolocation-custom-control branch September 19, 2023 15:09
sbb-design-systems-bot bot pushed a commit that referenced this pull request Sep 19, 2023
Refs: ROKAS-100

---------

Co-authored-by: Chris Dickinson <“christopher.dickinson@sbb.ch”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants