Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable mode is now mandatory #65

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Editable mode is now mandatory #65

merged 1 commit into from
Nov 6, 2021

Conversation

sbidoul
Copy link
Owner

@sbidoul sbidoul commented Nov 6, 2021

Now that PEP 660 is a thing and is supported by pip and flit at least, make editable install non-optional.

In retrospect, installing in non-editable mode was a bad UX anyway.

@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #65 (43cd638) into master (b7798b5) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   95.60%   95.33%   -0.27%     
==========================================
  Files          16       15       -1     
  Lines         932      921      -11     
  Branches      173      170       -3     
==========================================
- Hits          891      878      -13     
- Misses         27       28       +1     
- Partials       14       15       +1     
Impacted Files Coverage Δ
src/pip_deepfreeze/__main__.py 88.88% <ø> (-1.81%) ⬇️
src/pip_deepfreeze/sync.py 92.59% <ø> (ø)
src/pip_deepfreeze/pip.py 96.15% <100.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7798b5...43cd638. Read the comment docs.

@sbidoul sbidoul merged commit 7d558ef into master Nov 6, 2021
@sbidoul sbidoul deleted the editable-always branch November 6, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant