Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for buffer contents #64

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Support for buffer contents #64

merged 7 commits into from
Jun 4, 2024

Conversation

agarny
Copy link
Contributor

@agarny agarny commented Jun 4, 2024

This PR adds support for buffer contents by adding the following methods:

  • initializeFromBuffer();
  • addFileFromBuffer(); and
  • extractEntryToBuffer().

It also:

Fixes #61.
Fixes #63.

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

I still think, that the zipper issue should have been solved on the import target level (such that we won't require any of the variables in include_directory or worry about library names. But that can happen later.

@fbergmann fbergmann merged commit a8a4bba into sbmlteam:master Jun 4, 2024
@agarny agarny deleted the issue61 branch June 4, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zipper not found despite providing ZIPPER_LIBRARY and ZIPPER_INCLUDE_DIR Add support for buffer contents
2 participants