Refactor TLS feature flags #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbstp
reviewed
Nov 4, 2022
| @@ -21,5 +21,6 @@ cargo test --no-default-features --features compress-zlib-ng | |||
| cargo test --no-default-features --features form | |||
| cargo test --no-default-features --features multipart-form | |||
| cargo test --no-default-features --features json | |||
| cargo test --no-default-features --features tls | |||
| cargo test --no-default-features --features tls-rustls | |||
| cargo test --no-default-features --features tls-native | |||
There was a problem hiding this comment.
Can you also test tls-native-vendored? Just so we know it builds properly
There was a problem hiding this comment.
Good call, updated!
charlespierce
force-pushed
the
tls_feature_flags
branch
from
0331de2 to
550a919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Changes
__rustlsto indicate Rustls support is enabled (with either kind of root certificates)Notes