1.6.0 not compatible with Lagom 1.4.10

[ignasi35]

After Play 2.6.20 the Play dependency to sbt-native-packager bumped to 1.3.15.

sbt-reactove-app uses sbt-native-packager by extending DockerKeys. DockerKeys in sbt-native-packager changed in the 1.3.x family (new fields added in 1.3.12 and 1.3.14).

Using sbt-reactive-app with Play 2.6.21 is not possible:

...
[warn] There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings.
[info] Loading settings for project lagom-minimal-deployment-sample from build.sbt ...
[error] java.lang.AbstractMethodError
[error]         at com.typesafe.sbt.packager.docker.DockerKeys.$init$(Keys.scala:25)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$localImport$.<init>(SbtReactiveAppPlugin.scala:95)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$localImport$.<clinit>(SbtReactiveAppPlugin.scala)
[error]         at com.lightbend.rp.sbtreactiveapp.DeployableApp.projectSettings(Deploy.scala:193)
[error]         at com.lightbend.rp.sbtreactiveapp.DeployableApp.projectSettings$(Deploy.scala:36)
[error]         at com.lightbend.rp.sbtreactiveapp.BasicApp$.projectSettings(App.scala:260)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$.projectSettings(SbtReactiveAppPlugin.scala:109)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$.projectSettings(SbtReactiveAppPlugin.scala:46)
[error]         at sbt.internal.Load$.$anonfun$resolveProject$3(Load.scala:1062)
[error]         at scala.collection.TraversableLike.$anonfun$flatMap$1(TraversableLike.scala:240)
[error]         at scala.collection.immutable.List.foreach(List.scala:388)
...

Both sbt-reactive-app 1.5.0 and 1.6.0 fail.

This is arguably a Play issue and not a sbt-reactive-app issue though.

[ignasi35]

This issue doesn't belong to this repo. Moving to sbt-reactive-app. lightbend/sbt-reactive-app#168

Apologies,

[dwijnand]

Btw I think it's also an sbt-native-packager issue because adding a field to a trait is binary incompatible.

[muuki88]

Thanks for pointing this out 😃

Responsible PRs

• [Docker] add dockerEnvVars support #1137
• [Docker] add multiple docker tags support #1138

I think the main issue here is that these traits a public. They aren't meant to be use. As @dwijnand correctly points out one should use the autoImport object.

[muuki88]

Maybe we mark all *Keys traits as private?

[dwijnand]

That's also binary incompatible.

I think you should deprecate DockerKeys so users move away from it.

[dwijnand]

Also, I think you should MiMa check the code.

[muuki88]

That's also binary incompatible.

I know 😜 Deprecating and then making them private should be the way to go. Maybe now there's enough stuff to actually make a 2.x version.

#1185

Milestone 2.0