Fix the build in Travis #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.6.6 of gitbook started failing
|
One bit of confusion is that the Travis config for the source repository is pinned to the older precise containers, while building in Travis for a new fork will use their newer trusty images. https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming |
|
@ashawley Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #103 was merged, the test suite broke. I looked in to this and it seemed to be because of node, but I couldn't resolve it. Seems it was a problem with gitbook that was resolved in GitbookIO/gitbook-cli#60, but is still not entirely fixed by my measure.
For now, maybe just pin the version of gitbook-cli in Travis to the last version of gitbook-cli that was working, and use newer gitbook versions in the scripted tests?