-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo Protobuf workaround for build to work on Apple Silicon #1277
Conversation
For Protobuf 3.17.3 or higher, Apple Silicon is supported upstream.
What's the reason to no longer sync the version numbers between build.sbt and plugins.sbt? |
The following link opens: https://repo.maven.apache.org/maven2/com/github/os72/protoc-jar/3.11.4/ But not the following: https://repo.maven.apache.org/maven2/com/github/os72/protoc-jar/3.24.4/ So I thought there might be no matching protoc-jar version, therefore I removed the sync. |
I don't really understand this stuff, but 3.11.4 is also the latest at https://github.com/os72/protoc-jar and the readme there says
so I guess it's okay? in local testing (on my M2 Mac), I see this when I
and |
can you sign the Scala CLA? |
Yes. Just finished signing the CLA: https://www.lightbend.com/contribute/cla/scala/check/Friendseeker Thank you for your swift review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for the PR... always nice when we can remove build cruft |
As in https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3/, Apple Silicon Protobuf build is now available, therefore no need for workaround.
Reverts #1036