-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sessionStorage for burner wallet #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rin-st! Just pushed b9b4f6b
I think people should be able to use either one of them not both at same time (rainbowkitBurnerConnector
| rainbowkitSessionStorageBurnerWallet
). But since we are exposing both people can use both at same time and that can cause issue.
So just updated it to hvae similar API to how rianbowkit coinbase wallet has:
So similar to this in our case people would consume sessionStorage in this way:
import { rainbowkitBurnerWallet } from "burner-connector";
rainbowkitBurnerWallet.useSessionStorage = true
const wallets = [metaMaskWallet, rainbowkitBurnerWallet];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could u just give it a last pair of eyes / thoughts on last commit 🙌. Happy to merge without last commit but I think it makes more sense to have the API like this but not too strong opinion.
Yes I agree, thank you! Added small fix for default value and network |
Thanks @rin-st! Merging this 🙌 |
Context: scaffold-eth/se-2-challenges#250 (comment)
Also, to make it work we need to add the possibility to export it to
services/web3/wagmiConnectors.tsx
. So we need to templatize that fileDo you have any thoughts on how to make it another way?
@technophile-04