Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 1.0? #213

Closed
SethTisue opened this issue Mar 9, 2021 · 9 comments
Closed

Release version 1.0? #213

SethTisue opened this issue Mar 9, 2021 · 9 comments
Assignees

Comments

@SethTisue
Copy link
Member

SethTisue commented Mar 9, 2021

We've been in 0.9 releases for a long, long time now. We're adding MiMa in #211. I think it would be reasonable at this point to say, hey, this is 1.0 now. (We could do an RC first.)

@SethTisue
Copy link
Member Author

I guess I'll do this when Scala 3.0.0-RC2 comes out, since I'll need to be doing publishing then anyway.

@SethTisue SethTisue assigned SethTisue and unassigned SethTisue Mar 16, 2021
@SethTisue
Copy link
Member Author

Scala 3.0.0-RC2 is out. I will roll scala-java8-compat 1.0.0-RC1 today.

@SethTisue
Copy link
Member Author

1.0.0-RC1 is published

@smarter
Copy link
Member

smarter commented Apr 2, 2021

By the way, shouldn't this library be deprecated since most (all?) of its converters were merged into the 2.13 standard library (scala/scala#7458) ?

@SethTisue
Copy link
Member Author

SethTisue commented Apr 2, 2021

uh, good question. I don't think absolutely everything was moved, and stuff being in 2.13 doesn't help people crossbuilding to 2.12 (and 2.11)

at minimum, the README should be clear about what the situation is, for sure

perhaps we could have a 1.x series that keeps everything, and 2.x series that is 2.13+ only — if there are any converters that weren't ported, that is. if everything was ported, then the readme could just say "you don't need this if you're on 2.13+ only"

from the checklist on Lukas's PR it seems he intended to "make java8-compat a shim release for 2.13 that helps cross-building a codebase with 2.12 / 2.13", which would be a little different, I guess that means support cross-building by forwarding to the 2.13 stdlib implementations. that sounds nice, but it also sounds like work I don't want to do

@lrytz thoughts?

@lrytz
Copy link
Member

lrytz commented Apr 7, 2021

I don't think absolutely everything was moved

I think we moved everything, the only reason to keep this for 2.13 was cross-building with older Scala versions.

IIRC, we kept the converters in the 2.13 version of this module because it was the easiest way forward. The actual colleciton types are aliased: https://github.com/scala/scala-java8-compat/blob/main/src/main/scala-2.13+/scala/compat/java8/collectionImpl/package.scala

So "you don't need this if you're on 2.13+ only" is right.

@SethTisue SethTisue self-assigned this Apr 7, 2021
@SethTisue
Copy link
Member Author

thanks — I'll update the readme appropriately at the time I do the 1.0 release

@SethTisue
Copy link
Member Author

I have backpublished 1.0.0-RC1 for Scala 3.0.0-RC3. (Without doing anything else, yet.)

@SethTisue SethTisue mentioned this issue May 13, 2021
8 tasks
@SethTisue
Copy link
Member Author

only publishing remains: #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants