Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Wconf src filter not implemented #18782

Closed
povder opened this issue Oct 28, 2023 · 4 comments · Fixed by #18783
Closed

-Wconf src filter not implemented #18782

povder opened this issue Oct 28, 2023 · 4 comments · Fixed by #18783
Assignees
Labels
area:reporting Error reporting including formatting, implicit suggestions, etc itype:enhancement
Milestone

Comments

@povder
Copy link
Contributor

povder commented Oct 28, 2023

Compiler version

3.3.1


Scala 2's -WConf filters include src filter which allows configuring warnings for a given source path pattern. It is missing in Scala 3. It is handy for ignoring warnings for generated sources where you have no option of placing @nowarn annotations. Right now I'm facing a problem were I can't enable -Werror because of warnings reported in generated sources (in my case generated by ScalaPB protobuf compiler).

It would be great to bring all Scala2 WConf filters to Scala 3 but this issue is just about src. I am willing to contribute a pull request for this.

@povder povder added the stat:needs triage Every issue needs to have an "area" and "itype" label label Oct 28, 2023
@som-snytt
Copy link
Contributor

Duplicates #17634 which was deemed not regressive enough to warrant a ticket without further discussion.

@povder
Copy link
Contributor Author

povder commented Oct 28, 2023

Ah ok I didn't realize that before opening an issue I am supposed to search in resolved tickets as well.

@som-snytt
Copy link
Contributor

I remembered because someone commented on the discussion that they would like to fix it, but of course they will need an open ticket! So your timing is impeccable.

povder added a commit to povder/dotty that referenced this issue Oct 28, 2023
@SethTisue SethTisue changed the title -WConf src filter not implemented -Wconf src filter not implemented Oct 29, 2023
@sjrd sjrd added itype:enhancement area:reporting Error reporting including formatting, implicit suggestions, etc and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Oct 30, 2023
povder added a commit to povder/dotty that referenced this issue Oct 31, 2023
povder added a commit to povder/dotty that referenced this issue Oct 31, 2023
povder added a commit to povder/dotty that referenced this issue Nov 4, 2023
@henricook
Copy link

henricook commented Dec 9, 2023

Thanks for this @povder! I was looking it up because the issue prevents me using Play with Scala 3 (with warnings as errors), so this is very well timed for me personally :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:reporting Error reporting including formatting, implicit suggestions, etc itype:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants