Add windows CI #9647
Add windows CI #9647
Conversation
liufengyun
force-pushed
the
add-windows-ci
branch
from
fe18591
to
68fa419
Compare
.appveyor.yml
Outdated
| test_script: | ||
| - cmd: sbt "dotty-bootstrapped/dotc tests\pos\HelloWorld.scala" | ||
| - cmd: sbt sjsJUnitTests/test | ||
| - cmd: sbt test |
There was a problem hiding this comment.
test won't work on Windows at the moment. Although run tests basically work, all neg tests are completely broken on Windows, because they pervasively expect file names with /. Fixing those is probably best left to another day, or at least another PR. ;)
| @@ -199,7 +199,7 @@ final class FileZipArchive(jpath: JPath) extends ZipArchive(jpath) { | |||
| final class ManifestResources(val url: URL) extends ZipArchive(null) { | |||
| def iterator(): Iterator[AbstractFile] = { | |||
| val root = new DirEntry("/", null) | |||
| val dirs = new mutable.HashMap[String, DirEntry]; dirs.put("/", root) | |||
| val dirs = mutable.HashMap[String, DirEntry]("/" -> root) | |||
There was a problem hiding this comment.
Was this change intended in this PR?
There was a problem hiding this comment.
This is not intended, I'll move it to #9644.
liufengyun
force-pushed
the
add-windows-ci
branch
from
e93f056
to
ef80e4e
Compare
|
The JS tests failed because the default Node.js version is too old on the AppVeyor images. You can install a recent enough version with the following lines in You may also want to copy some other lines from that file, for example setting options to give more memory to sbt (currently it quickly disables compilation because the code cache is full): |
Copied from the scala-js/scala-js repo: https://github.com/scala-js/scala-js/blob/master/appveyor.yml
|
Merge, so other PRs can be green. |
Add windows CI
We need a basic windows CI to prevent regressions (See #9642)