fix JDK17 build #274
Merged
fix JDK17 build #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
jdk17
branch
2 times, most recently
from
31ad03b
to
4bafc91
Compare
bjaglin
commented
Jan 11, 2022
| if (System.getProperty("java.specification.version").toDouble < 17) | ||
| "1.2.7" // first release that can build 2.13 (as it bring a Zinc version with a compiler-bridge published for 2.13) | ||
| else | ||
| "1.5.5" // first release that supports JDK17 |
There was a problem hiding this comment.
There was a problem hiding this comment.
Interestingly, this bump revealed that a minor feature works with sbt 1.2.7 (<1.3) but not on sbt 1.5.5 (>1.3), see 30d8d4d. I don't think it's worth making it work as it would require a lot of code...
Skip the test instead of following the workaround suggested in Philippus/sbt-dotenv#118, as it would be global to all tests and we could miss actual violations that would prevent usage of the plugin for clients without the same hack.
- remove fragile, unnecessary assertions bringing false positives - document a non-working feature with sbt 1.3+ (untested until now)
bjaglin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261 (comment)