Add rewriting rule RedundantSyntax.finalObject #1496
Conversation
There was a problem hiding this comment.
Thanks for your PR!
It's definitely useful and generic enough to be a built-in check IMHO, but I am not sure this really belongs to DisableSyntax as something redundant is not a bad smell/feature like the other flags - the rule description reads "Reports an error for disabled features such as var or XML literals.".
Also, since it's redundant, this would really benefit from being a rewrite rule. I believe there are other redundant tokens that could be rewritten. What about starting a RedundantTokens syntactic rewriting rule to group them?
| @@ -0,0 +1,11 @@ | |||
| /* | |||
| rules = RedundantTokens | |||
| RedundantTokens.finalObject = true | |||
There was a problem hiding this comment.
some negative tests here where the final keyword is used on other symbols would be nice against regressions
scalafix-rules/src/main/scala/scalafix/internal/rule/RedundantTokens.scala
Outdated
Show resolved
Hide resolved
bjaglin
changed the title
|
Related: scala/bug#11094 |
Will do! (I'm trying to refrain from opening an editor on a Saturday though so the turnaround won't be as quick...) |
Interesting - does that mean we should deactivate this rule for members of non-final traits/classes on Scala 2.12 and earlier, and/or have that behaviour configurable? |
Since it's on by default and may have unexpected yet limited side effects on the bytecode, I'd say that a reference to that ticket in the docs would be enough. |
|
Hi @bplommer - will you have some time to follow-up and document this? Thanks! |
|
Sorry, I forgot all about this! I'll try to finish it off soon. |
bjaglin
changed the title
No description provided.