Scala 2.13 support #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzemin
force-pushed
the
feature/scala-2.13
branch
from
ee9539b
to
db3f050
Compare
krzemin
force-pushed
the
feature/scala-2.13
branch
from
db3f050
to
23bd4ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 92.51% 91.94% -0.58%
==========================================
Files 7 7
Lines 294 298 +4
Branches 59 63 +4
==========================================
+ Hits 272 274 +2
- Misses 22 24 +2
Continue to review full report at Codecov.
|
MateuszKubuszok
requested changes
Sep 24, 2018
krzemin
force-pushed
the
feature/scala-2.13
branch
from
23bd4ef
to
ed27799
Compare
|
Finally dropped scalatest, scalapb and bumped versions of few libraries. I think now it's ready to merge. |
MateuszKubuszok
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Scala 2.13 is going to be released soon, we need to cross support 2.13 too. I tried to play with latest available milestone (
2.13.0-M4) and it seems that number of required changes in quite short, most of them caused by new standard library.Deprecation of
TraversableWe may use
Iterableas well, covering all of the use cases. This doesn't even need special changes to 2.11/2.12 codebase.No support for
collection.to[AnotherCollection]But
collection.to(AnotherCollection)works great. We need to generate different code, depending on Scala version to keep the same semantics. But in 2.13 we need to use companion ref hack...Unsupported compiler options
In 2.13.0-M4 it seems following two flags are not understood by scalac:
-Yno-adapted-args,-Xexperimental.Dependencies
Before merging, we need to wait for following dependencies:
[ ] scalatest (already published snapshotswitched to utest3.0.6-SNAP2for2.13.0-M4)[ ] scalapbnot dependent on scalapb any more[ ] scalatexnot needed for cross compilationsbt-scoverageto1.6.0-M5)