Skip to content

Commit

Permalink
chore: Bump Scala version to LTS version
Browse files Browse the repository at this point in the history
  • Loading branch information
tgodzik committed Oct 16, 2023
1 parent bb070ef commit 7551c20
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- "'++2.12.18 test'"
- "'++2.13.12 test'"
# Minimal supported version
- "'++3.1.3 test'"
- "'++3.3.1 test'"
- "scripted"
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions .mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@ pull_request_rules:
- check-success="'++2.12.12! test' adopt@1.8"
- check-success="'++2.12.18 test' adopt@1.8"
- check-success="'++2.13.12 test' adopt@1.8"
- check-success="'++3.1.3 test' adopt@1.8"
- check-success="'++3.3.0 test' adopt@1.8"
- check-success="scripted adopt@1.8"
- check-success="'++2.12.12! test' adopt@1.11"
- check-success="'++2.12.18 test' adopt@1.11"
- check-success="'++2.13.12 test' adopt@1.11"
- check-success="'++3.1.3 test' adopt@1.11"
- check-success="'++3.3.0 test' adopt@1.11"
- check-success="scripted adopt@1.11"
- check-success="'++2.12.12! test' 17"
- check-success="'++2.12.18 test' 17"
- check-success="'++2.13.12 test' 17"
- check-success="'++3.1.3 test' 17"
- check-success="'++3.3.0 test' 17"
- check-success=scripted 17
actions:
merge:
Expand Down
4 changes: 1 addition & 3 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ import scala.collection.mutable

def scala212 = "2.12.18"
def scala213 = "2.13.12"
/* This should be kept at 3.1.3 until there is a
* need for change and in that case we should bump to LTS*/
def scala3 = "3.1.3"
def scala3 = "3.3.1"
def scala2Versions = List(scala212, scala213)
def allScalaVersions = scala2Versions :+ scala3

Expand Down
2 changes: 1 addition & 1 deletion mdoc-sbt/src/sbt-test/sbt-mdoc/basic/build.sbt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ThisBuild / scalaVersion := "2.12.18"
ThisBuild / crossScalaVersions := List("2.12.18", "2.13.12", "3.1.3", "3.3.0")
ThisBuild / crossScalaVersions := List("2.12.18", "2.13.12", "3.3.0", "3.3.1")

enablePlugins(MdocPlugin)
mdocJS := Some(jsapp)
Expand Down
4 changes: 2 additions & 2 deletions mdoc-sbt/src/sbt-test/sbt-mdoc/basic/test
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
> check
> ++2.13.12 mdoc
> check
> ++3.1.3 mdoc
> check
> ++3.3.0 mdoc
> check
> ++3.3.1 mdoc
> check
> set mdocIn := (ThisBuild / baseDirectory).value
-> mdoc
4 changes: 2 additions & 2 deletions mdoc-sbt/src/sbt-test/sbt-mdoc/scalajs-1.7/test
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
> check
> ++2.13.12 mdoc
> check
> ++3.1.3 mdoc
> check
> ++3.3.0 mdoc
> check
> ++3.3.1 mdoc
> check
> set mdocIn := (ThisBuild / baseDirectory).value
-> mdoc
1 change: 0 additions & 1 deletion tests/unit/src/test/scala/tests/markdown/CrashSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ class CrashSuite extends BaseMarkdownSuite {
|// java.lang.ArithmeticException: / by zero
|// at repl.MdocSession$MdocApp.hello$1(significant-indentation.md:19)
|// at repl.MdocSession$MdocApp.$init$$$anonfun$1(significant-indentation.md:20)
|// at repl.MdocSession$MdocApp.$init$$$anonfun$adapted$1(significant-indentation.md:21)
|```
|""".stripMargin
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ class NamespaceHygieneSuite extends BaseMarkdownSuite {
Compat.Scala3 ->
"""
|error: cannot import something called MdocSession.md:3:9:
|Reference to MdocSession is ambiguous,
|it is both defined in package repl
|Reference to MdocSession is ambiguous.
|It is both defined in package repl
|and imported by name subsequently by import util.{...}
|val x = MdocSession.nextInt(1)
| ^^^^^^^^^^^
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/src/test/scala/tests/markdown/NestSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ class NestSuite extends BaseMarkdownSuite {
""".stripMargin,
"""
|error: reset-scala3.md:9:15:
|no given instance of type Int was found for parameter e of method implicitly in object Predef
|No given instance of type Int was found for parameter e of method implicitly in object Predef
|implicitly[Int]
| ^
""".stripMargin
Expand Down Expand Up @@ -288,11 +288,11 @@ class NestSuite extends BaseMarkdownSuite {
""".stripMargin,
"""
|error: multi-reset-scala3.md:15:15:
|no given instance of type Int was found for parameter e of method implicitly in object Predef
|No given instance of type Int was found for parameter e of method implicitly in object Predef
|implicitly[Int]
| ^
|error: multi-reset-scala3.md:27:15:
|no given instance of type Int was found for parameter e of method implicitly in object Predef
|No given instance of type Int was found for parameter e of method implicitly in object Predef
|implicitly[Int]
| ^
""".trim.stripMargin
Expand Down

0 comments on commit 7551c20

Please sign in to comment.