Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkdownPart: identify mdoc code fence modifier #818

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

kitbellew
Copy link
Contributor

No description provided.

@kitbellew kitbellew requested a review from tgodzik November 3, 2023 14:39
@tgodzik
Copy link
Contributor

tgodzik commented Nov 3, 2023

Looks like tests.markdown.MultiModsSuite is failing, could you take a look?

@kitbellew
Copy link
Contributor Author

@tgodzik fixed, thank you.

@tgodzik tgodzik merged commit d7b59fb into scalameta:main Nov 5, 2023
14 checks passed
@kitbellew kitbellew deleted the 818 branch November 5, 2023 17:46
@kitbellew
Copy link
Contributor Author

@tgodzik will you be able to release it sometime soon? you said something about a new JDK.

@tgodzik
Copy link
Contributor

tgodzik commented Nov 6, 2023

Yes, some of the libraries stopped supporting JDK 8 so we needed to start releasing with JDK 11, which might be problematic if someone still needs to use JDK 8. Although, in those cases they should be fine to just stay with the particular version.

@tgodzik
Copy link
Contributor

tgodzik commented Nov 6, 2023

Anyway, I can do a release today if there is nothing else you would like to include?

@kitbellew
Copy link
Contributor Author

@tgodzik no, I wasn't planning to add anything yet, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants