Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalameta 4.9.x #842

Merged
merged 1 commit into from
Feb 22, 2024
Merged

scalameta 4.9.x #842

merged 1 commit into from
Feb 22, 2024

Conversation

bjaglin
Copy link
Member

@bjaglin bjaglin commented Feb 11, 2024

@bjaglin
Copy link
Member Author

bjaglin commented Feb 11, 2024

Opening this for visibility, ahead of the upcoming scalameta release

@bjaglin bjaglin changed the title latest scalameta contains breaking changes in internals scalameta 4.9.x Feb 21, 2024
@bjaglin
Copy link
Member Author

bjaglin commented Feb 21, 2024

Strictly speaking, 4.9.x is breaking because of scalameta/scalameta#3425, as quasiquotes expand to code referencing scala.meta.trees.Origin which does not exist in 4.8.x. But I am not sure this is a very relevant scenario for mdoc, so maybe a patch release is enough?

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues that could come up here. Thanks!

@tgodzik tgodzik merged commit ffa8c1f into scalameta:main Feb 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants