Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover - function application paramter highlighting #251

Open
dos65 opened this issue Jan 31, 2022 · 2 comments
Open

Hover - function application paramter highlighting #251

dos65 opened this issue Jan 31, 2022 · 2 comments

Comments

@dos65
Copy link
Member

dos65 commented Jan 31, 2022

Is your feature request related to a problem? Please describe.

It would be nice to have an additional info in hover for parameters in function application.
This should be useful for functions with large list of parameters.

Describe the solution you'd like

For example, in the following sample:

def foo(a: Int, b: String, c: Double, d: Boolean): Unit = ???
def baz: Double = ???

val a = foo(
  someIntFunc,
  bar,
  ba@@z,
  someFunc3, 
)

Instead of just having an info about baz the hover could also show foo signature with position of baz:

def baz: Double

Used as a parameter in :
def foo(
  a: Int, 
  b: String,
  c: Double, // <- bold/highlighted text ?
  d: Boolean
)

Describe alternatives you've considered

Additional contex

No response

Search terms

hover

@ckipp01
Copy link
Member

ckipp01 commented Jan 31, 2022

Screenshot 2022-01-31 at 13 11 26

But isn't this exactly what signature help shows? Adding this feature would sort of make signature help obsolete then no?

@dos65
Copy link
Member Author

dos65 commented Jan 31, 2022

@ckipp01 ouch, I tried to use signatureHelp before creating issue but it didn't work for me and I incorrectly decided that it might be showed only if it was triggered by completion.

I've checked it one more time - there was an issue with my keybindings 😄

Anyway, I think it's worth trying to combine hover with sigHelp to see all info at once.

Adding this feature would sort of make signature help obsolete then no?

I don't think that it will make it obsolete completely. It still be useful during typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants