Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier for users to change build server's memory requirements #2697

Closed
tgodzik opened this issue Apr 9, 2021 · 0 comments · Fixed by #3746
Closed

Make it easier for users to change build server's memory requirements #2697

tgodzik opened this issue Apr 9, 2021 · 0 comments · Fixed by #3746
Assignees
Labels
bloop Bloop related tickets configuration Tickets related to user configuration diagnostics Related to error/warning/info squiggles in the editor improvement Not a bug or a feature, but something general we can improve
Milestone

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Apr 9, 2021

When Metals runs it actually starts 2 processes. One is the server itself and the other is the build server (either Bloop or sbt). This is not always clear to the users and they might be surprised by a rouge process taking up a lot of their memory.

I propose that we expose metals.buildServerProperties similar to metals.serverProperties that would modify the proper json file (.bloop/bloop.json or .bsp/sbt.json) and then show a message to restart the server. This way users will not need to dig in the Bloop docs to find what they need to do.

Changing automatically someones bloop.json files is not perfect, but honestly I don't see any other solution here. And we can easily append to existing options.

Also, we could use the Metals javaHome for Bloop if it's not already set there.

We can add a warning to the setting, that it will modify a file on disk and give them a link to it?

Additional context

scalameta/metals-vscode#204

Search terms

bloop bsp memory sbt server

@tgodzik tgodzik added the improvement Not a bug or a feature, but something general we can improve label Apr 9, 2021
@tgodzik tgodzik added this to the Metals v1.0.0 milestone Apr 9, 2021
@zmerr zmerr self-assigned this Mar 17, 2022
@zmerr zmerr added configuration Tickets related to user configuration diagnostics Related to error/warning/info squiggles in the editor bloop Bloop related tickets labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloop Bloop related tickets configuration Tickets related to user configuration diagnostics Related to error/warning/info squiggles in the editor improvement Not a bug or a feature, but something general we can improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants