You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
File management should be done completely outside of NScumm.Audio.Players. It should not expect to have access to the file system. Instead of expecting a file, its API should expect a byte stream. It should be up to the user to decide (in their outside code) whether that byte stream comes from a file or a byte array in RAM or a web api or anything else it could be. This becomes particularly important on mobile devices or web apps which may not have permission to use the file system. Loading from a file system path could be provided as an option by a wrapper method to create the stream but should not be required.
I'll be putting together a PR that does this for ImfPlayer at least.
The text was updated successfully, but these errors were encountered:
File management should be done completely outside of NScumm.Audio.Players. It should not expect to have access to the file system. Instead of expecting a file, its API should expect a byte stream. It should be up to the user to decide (in their outside code) whether that byte stream comes from a file or a byte array in RAM or a web api or anything else it could be. This becomes particularly important on mobile devices or web apps which may not have permission to use the file system. Loading from a file system path could be provided as an option by a wrapper method to create the stream but should not be required.
I'll be putting together a PR that does this for ImfPlayer at least.
The text was updated successfully, but these errors were encountered: