Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with Preact currently works, however it throws an error in the console. #1

Closed
schalkventer opened this issue Jun 29, 2018 · 2 comments
Closed

Integration with Preact currently works, however it throws an error in the console. #1

schalkventer opened this issue Jun 29, 2018 · 2 comments
Assignees
@schalkventer
Labels
bug Something isn't working

Comments

@schalkventer
Copy link
Owner

Replicated at: https://s.codepen.io/schalkventer/debug/MXZErW

Uncaught DOMException: Failed to execute 'appendChild' on 'Node': The new child element contains the parent.
    at h (https://cdnjs.cloudflare.com/ajax/libs/preact/8.2.9/preact.min.js:1:2866)
    at M (https://cdnjs.cloudflare.com/ajax/libs/preact/8.2.9/preact.min.js:1:7615)
    at https://unpkg.com/react-html-connector@0.1.5/dist/index.min.js:1:2428
    at Array.forEach (<anonymous>)
    at t.default (https://unpkg.com/react-html-connector@0.1.5/dist/index.min.js:1:2383)
    at e.value (https://unpkg.com/react-html-connector@0.1.5/dist/index.min.js:1:6015)
    at https://s.codepen.io/schalkventer/debug/MXZErW:156:17
@schalkventer schalkventer added the bug Something isn't working label Jun 29, 2018
@schalkventer schalkventer self-assigned this Jun 29, 2018
@schalkventer
Copy link
Owner Author

schalkventer commented Jun 29, 2018 •
edited
Loading

Tried fixing in accordance with preactjs/preact#24 in commit 0da2b2d.

However now, HTML is no longer getting replaced in Preact.

@schalkventer
Copy link
Owner Author

Fixed in 88f9c99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schalkventer schalkventer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schalkventer