Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-selections not working #144

Open
hungupdown opened this issue Dec 20, 2023 · 5 comments
Open

Sub-selections not working #144

hungupdown opened this issue Dec 20, 2023 · 5 comments

Comments

@hungupdown
Copy link

eg. Select beer style "American porter" : 12,210 'recipes'
Try to make sub-selection: IBU max =51
Then shows 470,898 'matching recipes' ! So is not a sub-selection.

Result seems same using: Android 13 Chrome & Brave (normal or desktop mode) or Windows 10 PC Chrome browser.

Great data set, just need to narrow results down more.

@scheb
Copy link
Owner

scheb commented Dec 20, 2023

Did you go from the American Porter style page to the filters and added the ibu filter?

In that case, the style is not automatically preselected in the filters. Filters per default have nothing preselected. If you set both style and ibu in the filters, you get the recipes selected based on both criteria.

I know this is not ideal and I have it on my list of improvements to predefine the thing (e.g. style) you're currently looking at as a filter.

@hungupdown
Copy link
Author

Thanks, I did go from the American Porter style page to the filters and added the ibu filter, it seems easier seeing styles that way, rather than in the small scroll box wiithin filters.

I now see it works, when all done in filters.
But after changing beer style (in filters) it seems you must close the open recipes area, then reopen it before getting recipes in the new style. I think thats what initially threw me.

There still seems a few other odd things:
1):
Filters: American Porter + IBU min-24 + SRM min-25, shows 18 matching recipes.
But then "select the data"-"brewing recips" , there's 24 recipes shown, and every time "need more inspiration" selected, it comes up with a slightly different 24 recipes (ones checked, all seem within filter range).

2);
If you select single filter: American Porter there's 5,912 recipes. But via beer styles-American Porter there's 12,222 recipes.

If you manage an update, showing recipes in a scrollable and searchable table (maybe in new window) would be mush nicer, especially if list could show IBU; ABV; SRM and OG for each, and you could choose to order table by ascending or decending IBU etc.

Thanks again, P.

@hungupdown
Copy link
Author

It seems it's that after any filters are changed (checked with IBU), you must close, then re-open the recipes area to see recipes including change.

Another nice thing would be allowing keyword as filter. I found beer-analytics when looking for an evil dead red clone, couldn't find it then, but stumbled on a recipe just now, In American Amber.
Styles seem a bit of a pain, with things moving about whenever new style guides released. Evil dead red style now seems to be 'Commercial Specialty Beer'. You're much more likely to know a beers name, than the current style name.
P.

Repository owner deleted a comment from hungupdown Jan 3, 2024
@scheb
Copy link
Owner

scheb commented Jan 6, 2024

Thanks for the feedback. I've seen the issue with the recipe count as well, but haven't found the time yet to dig into it.

@scheb
Copy link
Owner

scheb commented Jan 30, 2024

Hey, just want to let you know that the number is recipes is now showing properly. It was a counting issue. The analysis was taking all recipes nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants