Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frameworks in the benchmark do not work properly! #18

Closed
limira opened this issue Feb 13, 2020 · 6 comments
Closed

Frameworks in the benchmark do not work properly! #18

limira opened this issue Feb 13, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@limira
Copy link

limira commented Feb 13, 2020

Running https://schell.github.io/mogwai/todomvc/perf/ by clicking the Steps Test button, all the Rust's frameworks do not add 100 items as expected.

@schell
Copy link
Owner

schell commented Feb 14, 2020

Well that's definitely interesting! How exactly are you testing this?

@schell
Copy link
Owner

schell commented Feb 14, 2020

I see exactly what you are talking about!

@schell schell added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Feb 14, 2020
@schell
Copy link
Owner

schell commented Feb 14, 2020

Unfortunately the benchmark is cargo culted from the TodoMVC project and is written in JS, so I haven't paid much attention to anything but adding frameworks and gathering the benchmarks. My guess is that there's some id or something that the bench runner is waiting for that doesn't exist.

@schell
Copy link
Owner

schell commented Feb 14, 2020

So at least in mogwai's case it looks like the first benchmark step needed a 'change' event instead of an input event or keydown event. This alters the benchmarks significantly but also brings into question the validity of all of the benchmarks, since none of the steps are verifying their results. I think the runner is flawed fundamentally and needs a rewrite, which I've been meaning to do. Thanks for your discovery!

@schell schell removed good first issue Good for newcomers help wanted Extra attention is needed labels Feb 14, 2020
@schell
Copy link
Owner

schell commented Feb 15, 2020

Hopefully I can get some new benchmarks up ASAP.

https://github.com/schell/todo-mvc-bench

@schell
Copy link
Owner

schell commented Feb 21, 2020

Looks like the technique employed by the previous (and somewhat standard) benchmarking suite was not confirming created todos, nor confirming the deletion of todos. This means it was really only measuring how long it took to "request' that todos be created or destroyed and not measuring the time it takes to realistically create or destroy them.

@schell schell changed the title All Rust frameworks in the benchmark do not work properly! Frameworks in the benchmark do not work properly! Feb 21, 2020
@schell schell closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants