You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thanks for the library! I've been happily using it after switching from clj-http. It's a part of our S3 internal client.
One thing I've noticed is, it looks like the convert-body-publisher function doesn't take into account a case when the body is a File object. The HttpRequest.BodyPublishers class has a static method to handle files: . ofFile(Path path). This is a good case for s3 because most often, we upload File objects there.
My question is, will you accept my PR if I extend the convert-body-publisher function with something like:
First of all, thanks for the library! I've been happily using it after switching from clj-http. It's a part of our S3 internal client.
One thing I've noticed is, it looks like the
convert-body-publisher
function doesn't take into account a case when the body is a File object. TheHttpRequest.BodyPublishers
class has a static method to handle files:. ofFile(Path path)
. This is a good case for s3 because most often, we upload File objects there.My question is, will you accept my PR if I extend the
convert-body-publisher
function with something like:UPD: #11
The text was updated successfully, but these errors were encountered: