Initial rack support?

[schneems]

Is there anything we can "know" by default? Like will there always be a config.ru? Can we require that an do something?

task :rack_load do
  require 'config.ru'
  DERAILED_APP = Foo.bar
end

cc @deafbybeheading @jroes

[jroes]

Whoa, sweet!

Yeah, I don't think there's much we can know. Maybe we can use Rack::Builder.parse_file somehow?

[msakrejda]

Nice. I honestly don't think I know enough about Rack to give useful input here--I've mostly just copied templates to bootstrap my apps--but for what it's worth, everything even moderately serious that I've worked on has had a config.ru. If that simplifies things but still doesn't handle all cases, you could always add it as another special case (like Rails is in the PR), and fall back to more manual setup if the file is missing?

[Kagetsuki]

I think using config.ru makes sense. Even if someone were to be using a rack app without config.ru (if that's even a thing?) they could always add it in order to support derailed_benchmarks.

[schneems]

Going to merge this in, we can still investigate a config.ru helper of some kind, but I don't have the knowledge right now. Maybe others going through the process of manually defining their rack setup tasks and sharing them can help make this a bit more general

[jroes]

So now that rack is supported, does the whole project name need to change, or README get updated?

[schneems]

Got it: https://github.com/schneems/derailed_benchmarks#rack-setup

[gangleton]

In order for the custom rake task to be loaded when rake perf:rack_load is invoked, you have to namespace it in your perf.rake. Might be helpful to put that in the README, unless I'm missing something?

[schneems]

@gangleton ahh, too true, could you give me a PR, I accidentally left that part out. Thanks for bringing it up ❤️

[gangleton]

No problem, just submitted a PR