Replace ReactDOM.findDOMNode() with ref. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. @D-TUCKER are you able to publish the latest to npm? |
|
Hmm good question. I don't have access to do that right now. I assume @schovi will either need to do it or give me access to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced findDOMNode with refs which is a more explicit and preferred method of accessing underlying DOM nodes. See:
https://reactjs.org/docs/react-dom.html#finddomnode
https://reactjs.org/docs/strict-mode.html#warning-about-deprecated-finddomnode-usage
jsx-eslint/eslint-plugin-react#678
Incidentally, this also resolves issue #70 where the "Unable to find node on an unmounted component" exception is thrown possibly due to different libraries using different versions of react-dom in the same project.