Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: Login Aea / clean config #4

Open
kevyn-raw opened this issue Jun 7, 2020 · 6 comments
Open

FeatureRequest: Login Aea / clean config #4

kevyn-raw opened this issue Jun 7, 2020 · 6 comments
Labels
backlog Will probably be considered in later releases enhancement New feature or request
Milestone

Comments

@kevyn-raw
Copy link
Contributor

It would be great if the "login" area could be included to the config files. Like a subdivision.

@kevyn-raw kevyn-raw added the enhancement New feature or request label Jun 7, 2020
@kevyn-raw kevyn-raw changed the title clean config - login area FeatureRequest: Login Aea / clean config Jun 7, 2020
@schw4rzlicht
Copy link
Owner

What do you mean by "login area"?

@kevyn-raw
Copy link
Contributor Author

A kind of main category for login data.
There the login data of MA and twitch are subordinate

@schw4rzlicht
Copy link
Owner

So instead of

{
  "ma": {
    ...
  },
  "twitch": {
    ...
  }, ...
}

you would suggest something like

{
  "login": {
    "ma": {
      ...
    },
    "twitch": {
      ...
    }
  }, ...
}

@kevyn-raw
Copy link
Contributor Author

Yes :)

@schw4rzlicht
Copy link
Owner

But what would be the benefits?

Imo it wouldn't help much regarding structure. Also effort vs. benefit is questionable. And it would introduce a breaking change (old configs wouldn't work any more).

@schw4rzlicht
Copy link
Owner

I think I reconsider it for v2.

@schw4rzlicht schw4rzlicht added this to the v2 milestone Jun 7, 2020
@schw4rzlicht schw4rzlicht added the backlog Will probably be considered in later releases label Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Will probably be considered in later releases enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants