Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vips no longer needs custom buildpack to be installed #2258

Closed
jrochkind opened this issue Jul 19, 2023 · 1 comment
Closed

vips no longer needs custom buildpack to be installed #2258

jrochkind opened this issue Jul 19, 2023 · 1 comment
Assignees

Comments

@jrochkind
Copy link
Contributor

Newlywords/heroku-buildpack-vips#36

We can now list libvips-tools in Aptfile to succesfully get vips command-line.

To get vips to include OpenJPEG/jp2 support, which we need for #2254 -- we need to go to heroku-22. It just works on heroku-22, but not heroku-20, not sure why.

This is true either with custom buildpack approach, or with new just Aptifle approach. We get OpenJPEG with heroku-22, not heroku-20.

So as part of this change, we should move to heroku-22 -- and #2090 is really a pre-requisite, I will probably prioritize doing that first.

Cc @eddierubeiz

@jrochkind jrochkind self-assigned this Jul 19, 2023
@jrochkind
Copy link
Contributor Author

Actually, nope, maybe not ready for prime-time, what we're doing is fine for now, and we don't get much advantage from trying to switch.

Newlywords/heroku-buildpack-vips#36 (comment)

We DO need to switch to heroku-22 to get the vips install to have OpenJPEG support though.

@jrochkind jrochkind closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant