Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multidomain source target split and merge #96

Open
YanisLalou opened this issue Feb 20, 2024 · 2 comments · May be fixed by #137
Open

Multidomain source target split and merge #96

YanisLalou opened this issue Feb 20, 2024 · 2 comments · May be fixed by #137
Labels
enhancement New feature or request

Comments

@YanisLalou
Copy link
Collaborator

Add the ability to have:

  • source_target_merge from utils.py to accept *List[arrays] with each list corresponding to one sample domain. Ex: List[X_domain_1, y_domain_1], List[X_domain_2, y_domain_2] ...
  • source_target_split from utils.py to return *List[arrays] with each list corresponding to one sample domain.
@YanisLalou YanisLalou added the enhancement New feature or request label Feb 20, 2024
@kachayev
Copy link
Collaborator

It sounds like a functionality of DomainAwareDataset, right?

@rflamary
Copy link
Collaborator

Not totally, if you have access to X,y,sample_domain but want to plot individual domains (or estimate their) or the reverse sucjh functions make sens but now that I see it probably it is better to have domain_mergeand domain_splitfunction that can also return/take a list of domain numbers corresponding to the arrays in the lists. For the moment we have no multidomain functiosn but it will be necessary to have such helpers inside the classes also (going back to DomainAwareDataset and doing a list of pack is not friendly for this )

@YanisLalou YanisLalou linked a pull request Mar 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TO_REVIEW] ConditionalTransferableComponentsAdapter Implementation YanisLalou/skada
3 participants
@kachayev @rflamary @YanisLalou