From 36c637c3f4412e24602bcec37e4cb6abf823da14 Mon Sep 17 00:00:00 2001
From: Henry Schreiner <henry.fredrick.schreiner@cern.ch>
Date: Sat, 8 Jun 2024 00:24:04 -0400
Subject: [PATCH] Apply suggestions from code review

---
 .github/workflows/emscripten.yaml | 2 +-
 pyproject.toml                    | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/.github/workflows/emscripten.yaml b/.github/workflows/emscripten.yaml
index f8163194..12b8d6e6 100644
--- a/.github/workflows/emscripten.yaml
+++ b/.github/workflows/emscripten.yaml
@@ -39,7 +39,7 @@ jobs:
           actions-cache-folder: emsdk-cache
 
       - name: Build
-        run: pyodide build --exports whole_archive
+        run: CXXFLAGS=-fexceptions LDFLAGS=-fexceptions pyodide build --exports whole_archive
 
       - uses: actions/setup-node@v4
         with:
diff --git a/pyproject.toml b/pyproject.toml
index 0e4859af..b7b9914d 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -117,11 +117,6 @@ sdist.exclude = [
 write_to = "src/boost_histogram/version.py"
 
 
-[tool.pyodide.build]
-cxxflags = "-fexceptions"
-ldflags = "-fexceptions"
-
-
 [tool.pytest.ini_options]
 minversion = "6.0"
 junit_family = "xunit2"