Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety #136

Closed
chrispap95 opened this issue Nov 6, 2022 · 3 comments
Closed

Thread safety #136

chrispap95 opened this issue Nov 6, 2022 · 3 comments

Comments

@chrispap95
Copy link
Collaborator

While troubleshooting configuring and building on MacOS, I realized that we haven't enabled the thread safety option that exists since 3.4.0. Do we want to recompile with that on? I am wondering whether this would solve the issue in #131 without that ugly patch.

@lgray
Copy link
Collaborator

lgray commented Nov 6, 2022

That we should give a try - given the annoyingness of getting macos to go and that it should not stop us from releasing 3.4.0.0. I'd check quick and if it simplifies the build in linux good.

@chrispap95
Copy link
Collaborator Author

After testing this on my fork, unfortunately, the seg fault is resolved by neither --enable-limited-thread-safety nor --enable-thread-safety. Nevertheless, both options seem to pass the tests as expected when the patch is applied. However, I am not sure how useful they are in our use case. (I have a feeling they are not)

@chrispap95
Copy link
Collaborator Author

I don't think this is important for now so closing. Feel free to reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants