Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Giving a fraction of samples instead of a number of samples in the Subsample class #238

Closed
gmartinonQM opened this issue Dec 20, 2022 · 1 comment · Fixed by #464
Closed

Giving a fraction of samples instead of a number of samples in the Subsample class #238

gmartinonQM opened this issue Dec 20, 2022 · 1 comment · Fixed by #464
Assignees
@BaptisteCalot
Labels
Enhancement Type: enhancement (new feature or request) Good first issue Easy issue to start to contribute to MAPIE Source: developers Proposed by developers.

Comments

@gmartinonQM
Copy link
Collaborator

gmartinonQM commented Dec 20, 2022 •
edited
Loading

Actually, the Subsample class in mapie/subsample.py is initiated with a parameter n_samples, which is necessarily an int. This implies to hard set the number of samples used.

Would it be possible to allow n_samples to be a float between 0 and 1, interpreted as a fraction of samples to take ?
@gmartinonQM gmartinonQM added the Enhancement Type: enhancement (new feature or request) label Dec 20, 2022
@LacombeLouis
Copy link
Collaborator

@gmartinonQM, thank you for the suggestion, this is something we need to look into, an issue also related to #231.

@thibaultcordier thibaultcordier added the Good first issue Easy issue to start to contribute to MAPIE label Mar 3, 2023
@thibaultcordier thibaultcordier added the Source: developers Proposed by developers. label Jul 4, 2023
@BaptisteCalot BaptisteCalot linked a pull request Jun 12, 2024 that will close this issue
238 giving a fraction of samples instead of a number of samples in the subsample class #464
Merged
7 tasks
@LacombeLouis LacombeLouis reopened this Jun 20, 2024
@github-actions github-actions bot mentioned this issue Jun 24, 2024
Open
@jawadhussein462 jawadhussein462 mentioned this issue Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BaptisteCalot BaptisteCalot

Labels
Enhancement Type: enhancement (new feature or request) Good first issue Easy issue to start to contribute to MAPIE Source: developers Proposed by developers.
Projects
None yet
Milestone
No milestone
4 participants
@gmartinonQM @LacombeLouis @BaptisteCalot @thibaultcordier