Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with version 1.4.2 of scikit-learn #432

Closed
LacombeLouis opened this issue Apr 18, 2024 · 0 comments · Fixed by #433
Closed

Issue with version 1.4.2 of scikit-learn #432

LacombeLouis opened this issue Apr 18, 2024 · 0 comments · Fixed by #433
Labels
Bug Type: bug
Milestone
0.9.0

Comments

@LacombeLouis
Copy link
Collaborator

LacombeLouis commented Apr 18, 2024 •
edited
Loading

Describe the bug
The tests will not pass for MapieCalibrator if you use version 1.4.2 of package scikit-learn.

To Reproduce
Steps to reproduce the behavior:

  1. Create an environment with version 1.4.2 of scikit-learn.
  2. make tests

Expected behavior
Tests should pass with the new version of scikit-learn.

Desktop (please complete the following information):

  • OS: macos - 14.4.1 (23E224)
  • MAPIE Version: 0.8.3
@LacombeLouis LacombeLouis added the Bug Type: bug label Apr 18, 2024
@LacombeLouis LacombeLouis linked a pull request Apr 18, 2024 that will close this issue
FIX: Put lower threshold for difference #433
Merged
7 tasks
@LacombeLouis LacombeLouis changed the title Issue with mapie-dev environment Issue with version 1.4.2 of scikit-learn Apr 19, 2024
@LacombeLouis LacombeLouis added this to the 0.9.0 milestone Apr 25, 2024
@github-actions github-actions bot mentioned this issue Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Type: bug
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

FIX: Put lower threshold for difference scikit-learn-contrib/MAPIE
1 participant
@LacombeLouis