Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌕 complete scipy.signal #99

Closed
21 tasks done
jorenham opened this issue Oct 18, 2024 · 4 comments · Fixed by #385
Closed
21 tasks done

🌕 complete scipy.signal #99

jorenham opened this issue Oct 18, 2024 · 4 comments · Fixed by #385
Labels
scipy.signal status: in progress stubs: untyped Annotations that use `Untyped`
Milestone
1.15.0.0

Comments

@jorenham
Copy link
Collaborator

jorenham commented Oct 18, 2024 •
edited
Loading

it uses Untyped* 662 628 623 517 506 453 296 186 156 times
@jorenham jorenham added scipy.signal stubs: untyped Annotations that use `Untyped` labels Oct 18, 2024
@jorenham jorenham assigned jorenham and unassigned jorenham Oct 25, 2024
This was referenced Nov 2, 2024
Merged
Merged
@jorenham

This comment was marked as resolved.

Sign in to view
@pavyamsiri pavyamsiri mentioned this issue Nov 24, 2024
Merged
@pavyamsiri pavyamsiri mentioned this issue Nov 29, 2024
Merged
@jorenham jorenham changed the title complete scipy.signal 🌕 complete scipy.signal Dec 6, 2024
@jorenham
Copy link
Collaborator Author

jorenham commented Dec 8, 2024

@pavyamsiri are you currently working on a particular module or something? Because I'd like to work on this as well, and we should probably avoid a situation where we're both working on the same code.

@pavyamsiri
Copy link
Contributor

Not currently no. The remaining modules have a lot of functions in them so I haven't done any work on them yet. I'm not sure when I'll get back to working on this yet so you can have free reign over which ones you want to work on.

@jorenham
Copy link
Collaborator Author

jorenham commented Dec 8, 2024

Not currently no.

Ok, no problem! If there's anything specific you'd like to work on, let me knoow, and I'll "reserve" it for you :)

The remaining modules have a lot of functions in them so I haven't done any work on them yet.

Yea there are a couple of real "plus-sized" modules left 😅. It's probably a good idea to split those up. At first glance there appear to be some natural clusters of functions in e.g. _filter_design and _signaltools, so I guess that could help.

FYI, I'd also gladly accept single-function "coffee-break" PR's 😄.

@jorenham jorenham mentioned this issue Dec 9, 2024
Merged
@jorenham jorenham mentioned this issue Dec 17, 2024
Merged
This was referenced Dec 24, 2024
Merged
Merged
Merged
Merged
@jorenham jorenham added this to the 1.15.0.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scipy.signal status: in progress stubs: untyped Annotations that use `Untyped`
Projects
None yet
Milestone
1.15.0.0
Development

Successfully merging a pull request may close this issue.

✨ signal: complete _ltisys.* scipy/scipy-stubs
2 participants
@jorenham @pavyamsiri