Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rackup has moved to it's own gem #419

Open
stbenjam opened this issue Sep 13, 2022 · 2 comments
Open

Rackup has moved to it's own gem #419

stbenjam opened this issue Sep 13, 2022 · 2 comments

Comments

@stbenjam
Copy link

In rack/rack#1937, rackup was moved to a different gem, so the message from the assemble script is incorrect.

The error says:

if ! bundle exec rackup -h &>/dev/null; then
echo "WARNING: Rubygem Rack is not installed in the present image."
echo " Add rack to your Gemfile in order to start the web server."
fi

This should say rackup if rack is >= 3.x

@phracek
Copy link
Member

phracek commented Aug 23, 2023

@stbenjam Can you please provide pull request that fixes this issue, as you are expert?

@stbenjam
Copy link
Author

I'm not an s2i expert so I don't even know how I'd begin to test my change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants