Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.2 #499

Closed
wants to merge 1 commit into from
Closed

Add Ruby 3.2 #499

wants to merge 1 commit into from

Conversation

pvalena
Copy link
Member

@pvalena pvalena commented Aug 22, 2023

In Fedora container:

bash-5.2$ ruby -v
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]

Build log: https://gist.github.com/pvalena/4caf0873c714acc8e2b14dc6d88de315

@phracek
Copy link
Member

phracek commented Aug 23, 2023

We have agreed on the internal meeting, that ruby-3.2 container will not be part of sclorg/s2i-ruby-container. We will skip it and later on add ruby-3.3.

@jackorp Am I right?

@jackorp
Copy link
Contributor

jackorp commented Aug 23, 2023

Yep, no Ruby 3.2 for sclorg/s2i-ruby-container.

For Fedora IIRC the comment was that if the community really wants it, we can merge, build and it's on a self-support basis. As in, you find a bug, you fix it yourself.

@pvalena
Copy link
Member Author

pvalena commented Aug 24, 2023

This is just for testing purposes... can I push it to 3.2-experimental branch or similar?

@zmiklank
Copy link
Contributor

Related issue: #461.

@zmiklank
Copy link
Contributor

This is just for testing purposes... can I push it to 3.2-experimental branch or similar?

Will it bring you any benefits to move this from your fork to non-main sclorg branch?

@pvalena
Copy link
Member Author

pvalena commented Aug 28, 2023

This is just for testing purposes... can I push it to 3.2-experimental branch or similar?

Will it bring you any benefits to move this from your fork to non-main sclorg branch?

Just for transparency. In case someone wants to experiment with it as well.

@pvalena
Copy link
Member Author

pvalena commented Aug 28, 2023

We have agreed on the internal meeting, that ruby-3.2 container will not be part of sclorg/s2i-ruby-container. We will skip it and later on add ruby-3.3.

@jackorp Am I right?

I just want to check that everything still works with Ruby 3.2 even if it's not packaged. E.g. using Ruby from my COPR: https://copr.fedorainfracloud.org/coprs/pvalena/ruby/

@pvalena
Copy link
Member Author

pvalena commented Aug 28, 2023

Btw. there's like 20 other random branches, so it probably doesn't matter...

@zmiklank
Copy link
Contributor

Btw. there's like 20 other random branches, so it probably doesn't matter...

That is true, but they are kind of polluting the repository and it would be difficult to get rid of them and make sure not to delete someone's work-in-progress. I would therefore suggest primarily using forks in the future.
However, your point seem like a valid one to me.

@pvalena
Copy link
Member Author

pvalena commented Aug 29, 2023

@pvalena
Copy link
Member Author

pvalena commented Aug 29, 2023

Thanks for the comments!

@pvalena pvalena closed this Aug 29, 2023
@pvalena
Copy link
Member Author

pvalena commented Aug 29, 2023

And here's the built image, in case someone's interested: quay.io/s2i-ruby/fedora:3.2-experimental

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants