-
-
Notifications
You must be signed in to change notification settings - Fork 115
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: warn when a flow is deleted (#894)
Co-authored-by: Matthias Rolke <mr.amtrack@gmail.com>
- Loading branch information
Showing
9 changed files
with
484 additions
and
455 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| 'use strict' | ||
| import { expect, jest, describe, it } from '@jest/globals' | ||
|
|
||
| import { DELETION } from '../../../../src/constant/gitConstants' | ||
| import { MetadataRepository } from '../../../../src/metadata/MetadataRepository' | ||
| import FlowHandler from '../../../../src/service/flowHandler' | ||
| import type { Work } from '../../../../src/types/work' | ||
| import { getGlobalMetadata, getWork } from '../../../__utils__/globalTestHelper' | ||
|
|
||
| jest.mock('../../../../src/utils/fsHelper') | ||
|
|
||
| const objectType = { | ||
| directoryName: 'flows', | ||
| inFolder: false, | ||
| metaFile: false, | ||
| suffix: 'flow', | ||
| xmlName: 'Flow', | ||
| } | ||
| const basePath = `force-app/main/default/${objectType.directoryName}` | ||
| let work: Work | ||
| beforeEach(() => { | ||
| jest.clearAllMocks() | ||
| work = getWork() | ||
| }) | ||
|
|
||
| describe('flowHandler', () => { | ||
| let globalMetadata: MetadataRepository | ||
| beforeAll(async () => { | ||
| globalMetadata = await getGlobalMetadata() | ||
| }) | ||
| describe('when a flow is deleted', () => { | ||
| it('warns the user not to', async () => { | ||
| // Arrange | ||
| const sut = new FlowHandler( | ||
| `${DELETION} ${basePath}/MyFlow.${objectType.suffix}-meta.xml`, | ||
| objectType, | ||
| work, | ||
| globalMetadata | ||
| ) | ||
| expect(work.warnings.length).toBe(0) | ||
|
|
||
| // Act | ||
| await sut.handle() | ||
|
|
||
| // Assert | ||
| expect(work.warnings.length).toBe(1) | ||
| }) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| 'use strict' | ||
| import { format } from 'util' | ||
|
|
||
| import messages from '../locales/en' | ||
|
|
||
| import StandardHandler from './standardHandler' | ||
|
|
||
| export default class FlowHandler extends StandardHandler { | ||
| public override async handleDeletion() { | ||
| await super.handleDeletion() | ||
| this.warnFlowDeleted() | ||
| } | ||
|
|
||
| private warnFlowDeleted() { | ||
| this.work.warnings.push( | ||
| new Error(format(messages.warningFlowDeleted, this._getElementName())) | ||
| ) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.