Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply ignore settings when copying file #745

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Dec 28, 2023

Explain your changes


Ensure ignore service is called when copying files

Does this close any currently open issues?


closes #744

  • Jest tests added to cover the fix.

@scolladon
Copy link
Owner Author

Could you help us with the end user testing @mmindenhall please ?

You can follow those steps to install the plugin from this PR locally

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@d5974f2). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #745   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        35           
  Lines           ?       997           
  Branches        ?       100           
========================================
  Hits            ?       997           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Jan 1, 2024

Code Climate has analyzed commit 526cc30 and detected 0 issues on this pull request.

View more on Code Climate.

@mmindenhall
Copy link
Contributor

Hi @scolladon,

Apologies for the delayed reply...I was on vacation all of last week. I just did the following to verify your fix:

  1. Followed your instructions to install the plugin from this PR branch
  2. Re-ran the command I posted in Jest tests copied to output folder when using --generate-delta #744 against my fork of the sfdx-git-delta-reproduction-playground
  3. Verified that the __tests__ folder and its contents are no longer copied to the plugin output folder

Thanks!

@scolladon
Copy link
Owner Author

Thanks for your contribution on validating the fix @mmindenhall

@scolladon scolladon merged commit d6f99d3 into main Jan 3, 2024
23 of 24 checks passed
@scolladon scolladon deleted the fix/ignore-copy branch January 3, 2024 07:19
Copy link

github-actions bot commented Jan 9, 2024

Shipped in release v5.32.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.32.0

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest tests copied to output folder when using --generate-delta
2 participants