-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prefer using iproute2 instead of ifconfig #1090
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a comment, preferably in the commit message, about why are we making this change?
e8a84d5
to
80b3632
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message starts with chore:
(which is used for something outside the code, such as library and CI setups), but I think this is more like fix:
because this fixes an actual problem #1089.
Also, a test for wol
is failing.
Thanks for your review and patience :) I learned the |
ec1b4b3
to
962e9ca
Compare
I rebased it and adjusted the code comment and the commit message. |
The test for |
Thanks! So a
for
for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I added another commit to solve another issue in the test framework. I think now this is ready.
For `_comp_compgen_available_interfaces`, we prefer to use ip (iproute) since long interface names will be truncated by ifconfig (respective packages in the operating system, e.g. inetutils) [1]. Even for the other functions that use "ifconfig" and "ip", we change to use `ip` because `ip`'s behavior is more uniform among the systems and also `ip` is becoming more common in Linux distributions. [1]: https://github.com/scop/bash-completion/pull/1090/files Co-authored-by: Koichi Murase <myoga.murase@gmail.com> Co-authored-by: Yedaya Katsman <43016107+yedayak@users.noreply.github.com>
To test `_comp_compgen_xinetd_services`, we have been using a directory /test/fixtures/shared/bin (which contained two files `arp` and `ifconfig`as a mock /etc/xinetd.d. However, the directory /test/fixtures/shared/bin is shared with other tests, and the contents of the files therein are not proper xinetd configurations. We want to prepare a separate directory for a mock /etc/xinetd.d. This patch adds it under /test/fixtures/_comp_compgen_xinetd_services/xinetd.d.
resolves #1089
Same with this
bash-completion/completions/wol
Line 18 in 2b7fc19